Opened 5 months ago

#18559 new defect

Fix wxwidgets.props for the official binaries distribution

Reported by: vadz Owned by:
Priority: normal Milestone: 3.1.4
Component: build Version: 3.1.3
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

This is embarrassing, but wxwidgets.props included in the binaries distribution doesn't actually work. There are several problems with it:

  1. Adding wxMSVC_VERSION_ABI_COMPAT to the line defining WXUSINGDLL only works for configurations named "DLL Debug/Release", but as we only provide the DLLs, both symbols should actually be defined unconditionally in this version of the file.
  2. Similarly, we need to define wxLibTypeSuffix as "dll" unconditionally.
  3. Finally, we need to define wxCompilerPrefix correctly, which is just not the case now.

The solution is probably to have some wxUsingOfficialBinaries variable and modify build/msw/wx_setup.props itself to take it into account.

Alternatively, we could have a completely separate wxwidgets_official.props that would be distributed with the binaries. But there are clearly more changes required than is reasonable to do on the fly in build/tools/msvs/package.bat with simple substitutions.

Change History (0)

Note: See TracTickets for help on using tickets.