#18287 closed defect (fixed)

wxGLCanvas cannot get touch events

Reported by: dkulp Owned by: csomor
Priority: normal Milestone:
Component: wxOSX Version: dev-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

With the change on OSX from generic wxNSView to the wxNSCustomOpenGLView, we lost the ability to get touch events on GL canvas's. The problem is that the EnableTouchEvents checks the IsUserPane method which, with the new code, returns false. Most likely, line 162 of glcanvas.mm where we do "wxWidgetCocoaImpl* c = new wxWidgetCocoaImpl( this, v );" needs to be updated to be "wxWidgetCocoaImpl* c = new wxWidgetCocoaImpl( this, v, false, true );" to set the m_userPane variable to true so that the user level stuff works.

Change History (5)

comment:1 Changed 20 months ago by csomor

  • Status changed from new to infoneeded_new

I fear the IsUserPane true might lead to other problems, as I check that quite often and deal with events differently, I also think I had a problem where I did have it at true somewhere in the past.

Could you please test what happens if you just for testing enable the former IsUserPane() in window.mm 3528 unconditionally ? I might do things then with a CanHandleTouchEvents on the implementation or something. Thanks.

Last edited 20 months ago by csomor (previous) (diff)

comment:2 Changed 20 months ago by dkulp

  • Cc dan@… added
  • Status changed from infoneeded_new to new

Not sure what you are asking. If I comment out the call to IsUserPane() so we always go into the body of the if block. It seems to work fine. I get the events. Thus, I'm OK with that.

comment:3 Changed 20 months ago by csomor

  • Owner set to csomor
  • Status changed from new to accepted

that's exactly what I needed, to know whether it is sufficient just to make this clause active, without having to make it return true for IsUserPane

Thanks

comment:4 Changed 20 months ago by csomor

  • Status changed from accepted to infoneeded

could you please test with 5581e507

Last edited 20 months ago by csomor (previous) (diff)

comment:5 Changed 13 months ago by dkulp

  • Cc dan@… removed
  • Resolution set to fixed
  • Status changed from infoneeded to closed
Note: See TracTickets for help on using tickets.