Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9492 closed build error (fixed)

vc6 compilo

Reported by: troelsk Owned by:
Priority: normal Milestone:
Component: wxMSW Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

ATTACH_PARENT_PROCESS is not in the VC6 SDK.

Attachments (5)

vc6-app.patch download (500 bytes) - added by troelsk 10 years ago.
vc6-rawbmp.patch download (484 bytes) - added by troelsk 10 years ago.
Also breaking the build today
vc6-strconv.patch download (733 bytes) - added by troelsk 10 years ago.
Also breaking the build today
vc6-getancestorparent.patch download (558 bytes) - added by troelsk 10 years ago.
vc6-dialogsample.patch download (1.3 KB) - added by troelsk 10 years ago.

Download all attachments as: .zip

Change History (16)

Changed 10 years ago by troelsk

Changed 10 years ago by troelsk

Also breaking the build today

Changed 10 years ago by troelsk

Also breaking the build today

comment:1 Changed 10 years ago by troelsk

Three things breaking the build now.

comment:2 Changed 10 years ago by vadz

  • Resolution set to fixed
  • Status changed from new to closed

Fixed (independently, I didn't notice this patch before because of its summary, please open new reports for new fixes, TIA).

BTW, it would be great if you (or another VC6 user reading this) could set up a build slave for the buildbot using it, we keep breaking the VC6 build because few people among developers use it regularly.

comment:3 Changed 10 years ago by troelsk

vc6-strconv.patch got applied, but not vc6-rawbmp.patch and vc6-app.patch??

comment:4 Changed 10 years ago by vadz

I didn't apply the other patches because I had built the library successfully without them but this was because I was using newer SDK and the library build doesn't use wx/rawbmp.h. Aplied the app.patch and modified version of rawbmp.patch not breaking compilation with standard-conforming compilers as r54016.

comment:5 Changed 10 years ago by troelsk

r54016

Tricky business. Thanks.

comment:6 Changed 10 years ago by troelsk

  • Resolution fixed deleted
  • Status changed from closed to reopened

GetAncestor() may not exist:
vc6-getancestorparent.patch

Changed 10 years ago by troelsk

Changed 10 years ago by troelsk

comment:7 Changed 10 years ago by troelsk

vc6-dialogsample.patch:

Classes (wxString) in a static array is not good. Also, some char/wxString problem is in here:

C:\svn\wx\samples\dialogs\dialogs.cpp(2143) : error C2440: 'initializing' : cannot convert from 'const int' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2143) : error C2440: 'initializing' : cannot convert from 'char [5]' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2144) : error C2440: 'initializing' : cannot convert from 'const int' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2144) : error C2440: 'initializing' : cannot convert from 'char [4]' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2145) : error C2440: 'initializing' : cannot convert from 'const int' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2145) : error C2440: 'initializing' : cannot convert from 'char [4]' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2146) : error C2440: 'initializing' : cannot convert from 'const int' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

C:\svn\wx\samples\dialogs\dialogs.cpp(2146) : error C2440: 'initializing' : cannot convert from 'char [8]' to 'struct TestMessageBoxDialog::BtnInfo'

No constructor could take the source type, or constructor overload resolution was ambiguous

comment:8 Changed 10 years ago by vadz

  • Status changed from reopened to infoneeded_new

[could you please open different tickets for different problems?]

Sorry, I don't understand the problem with using wxString in static arrays. Could you please show the error message?

As for replacing GetAncestor(GA_PARENT) with GetParent(), they're 'not' the same, this is why I used the former. But I'll change this code anyhow.

comment:9 Changed 10 years ago by troelsk

  • Status changed from infoneeded_new to new

Error message: C2440, above.

comment:10 Changed 10 years ago by vadz

  • Resolution set to fixed
  • Status changed from new to closed

Should be fixed by r55547, thanks.

comment:11 Changed 10 years ago by VZ

(In [55547]) don't use wxStrings in a statically initialized array of structs, VC6 doesn't like it (re-closes #9492)

Note: See TracTickets for help on using tickets.