Opened 7 years ago

Closed 7 years ago

#9161 closed enhancement (fixed)

MSW SYSTEMTIME in wxDateTime

Reported by: troelsk Owned by: vadz
Priority: low Milestone:
Component: wxMSW Version:
Keywords: wxDateTime Cc: troelsk
Blocked By: Blocking:
Patch: yes

Description

Move SYSTEMTIME handling into wxDateTime, out of the calendar/date controls.
Patch: Added
ctor(const SYSTEMTIME&)
Set(const SYSTEMTIME&)
GetAsSystemTime(SYSTEMTIME*) (analogue to GetAsDOS)

Attachments (2)

datetime-systemtime-2.patch download (7.3 KB) - added by troelsk 7 years ago.
datetime-systemtime-3.patch download (8.8 KB) - added by troelsk 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by troelsk

comment:1 Changed 7 years ago by troelsk

Turns out that a prototype is required.
[datetime.h]
#ifdef WXMSW
struct _SYSTEMTIME;
#endif

File Added: datetime-systemtime-2.patch

comment:2 Changed 7 years ago by vadz

  • Component set to wxMSW
  • Keywords wxDateTime added
  • Owner set to vadz
  • Priority changed from normal to low
  • Type set to enhancement

I agree that these functions probably do belong to wxDateTime but could you please update interface/datetime.h accordingly?

I also think that "system time" is not precise enough, I'd rather call the functions SetFrom/GetAsMSWSysTime() to make it clear that these functions are Windows-specific.

Changed 7 years ago by troelsk

comment:3 Changed 7 years ago by troelsk

Done.
Thanks

comment:4 Changed 7 years ago by vadz

  • Resolution set to fixed
  • Status changed from new to closed

Applied, thanks a lot!

Note: See TracTickets for help on using tickets.