gtk wxChoice/wxCombobox refactoring

[wojdyr]

wxChoice uses GtkComboBox.
The code from wxComboBox was moved to wxChoice, and wxCombobox was derived from wxChoice (like on MSW). Very little new code was written.
wxComboBox::DoGetBestSize() was commented out.

include/wx/gtk/choice.h | 33 +--
include/wx/gtk/combobox.h | 68 +-----
samples/widgets/choice.cpp | 7
src/gtk/choice.cpp | 484 +++++++++++++--------------------------------
src/gtk/combobox.cpp | 221 --------------------
5 files changed, 182 insertions(+), 631 deletions(-)

[roebling]

wxChoice uses GtkComboBox

There is no reason for wxChoice to use GtkComboBox.

[wojdyr]

There is no reason to use GtkOptionMenu which, as a comment in choice.cpp says, has been deprecated since GTK+ 2.3.0 in favour of GtkComboBox.
Note that the patch removes most of the code from choice.cpp, but doesn't add a new code, the code for GtkComboBox is shared with wxComboBox.

The patch needs to be changed, I'll leave wxComboBox::DoGetBestSize() as it was for now and will add it also to wxChoice.

[vadz]

Thanks, I've applied your patch.

I noticed that pressing the "Run tests" button in the choice and combobox pages of the widgets sample results in multiple test failures. This is not due to this patch as it also happened before it but if you still have this code fresh in your memory it would be great if you could have a look at it. TIA!

[wojdyr]

"Run tests" works for me - all test are passed.

I'm afraid DoGetBestSize() should be reverted. As Robert wrote recently on wx-dev, it is necessary. I haven't investigated it, but I think it's safer to leave it for now. The patch
gtk-choice-size.diff re-adds DoGetBestSize() as it was before, but this time to choice.cpp

[vadz]

Applied DoGetBestSize() patch, thanks.