Incorrect icons' alignment in menus

[hzd_byte]

There is incorrect icons' alignment in menus..
In wxWidgets 2.8.0 there was no bug.

Look at attached image.

[hzd_byte]

Icons' alignment bug

[vadz]

The icons seem to be aligned just fine to me, but they seem to be cut off on the left, is this what you mean?

As usual, having a patch showing the problem in the menu or ownerdrawm sample would be very helpful.

[hzd_byte]

wx_2.8.0_icons

[hzd_byte]

Look at these menu's icons in wxWidgets 2.8.0 (attached image)
File Added: wx_2.8.0_menu_icons.JPG

[vadz]

Yes, something changed... Can you see the same effect in the ownerdrw sample or not?

[hzd_byte]

There is all ok in the ownerdrw sample.. Icons correctly drawn.

[vadz]

And could you please try to reproduce the bug in ownerdrw sample? I.e. try to provide minimal modification to it showing the problem?

It's going to be rather difficult for us to fix the bug without being able to see it I'm afraid.

Thanks!

[hzd_byte]

In the "menu" sample I changed line

item->SetBitmap(copy_xpm);

with

wxInitAllImageHandlers();
item->SetBitmap(wxBitmap(_T("sound.gif"), wxBITMAP_TYPE_ANY));

"sound.gif" is an 34x31 pixels image.

[vadz]

I can indeed see that the bitmap is cut off on the left side with the following patch (even with the latest trunk):

Index: samples/menu/menu.cpp
===================================================================
--- samples/menu/menu.cpp       (revision 54766)
+++ samples/menu/menu.cpp       (working copy)
@@ -59,6 +59,8 @@
 #include "copy.xpm"
 #endif

+#include "wx/dcmemory.h"
+
 // ----------------------------------------------------------------------------
 // classes
 // ----------------------------------------------------------------------------
@@ -442,7 +444,14 @@
     wxMenuItem *item = new wxMenuItem(fileMenu, Menu_File_ClearLog,
                                       _T("Clear &log\tCtrl-L"));
 #if wxUSE_OWNER_DRAWN || defined(__WXGTK__)
-    item->SetBitmap(copy_xpm);
+    wxBitmap bmp(34, 31);
+    wxMemoryDC dc(bmp);
+    dc.SetBrush(*wxBLACK_BRUSH);
+    dc.Clear();
+    dc.SetPen(*wxRED_PEN);
+    dc.DrawLine(0, 0, 34, 31);
+    dc.DrawLine(0, 31, 34, 0);
+    item->SetBitmap(bmp);
 #endif
     fileMenu->Append(item);
     fileMenu->AppendSeparator();

[catalin]

This no longer happens in 2.9-svn. The bitmap is correctly aligned, tested with the test code in comment:7

[vadz]

Hmm, I wonder what has actually fixed this as I thought we still had some problems in the owner draw menu code. But if it works now, all the better, thanks for testing!