wxLocale::GetSystemEncodingName() returns empty string under OS X

[pitrou]

On MacOS X, wx.Locale.GetSystemEncodingName() returns
the empty string whereas wx.Locale.GetSystemEncoding()
returns the proper value.

This is a problem when you need to use the standard
Python methods unicode.encode() and str.encode(). They
expect the literal name of the encoding (e.g.
('utf-8')), not a wx-custom numeric values.

GetSystemEncodingName() does return the proper value
under Linux and Windows.

[wxsite]

transitioning old 'assigned' status to new 'confirmed' status

[oneeyeman]

Calling this function on Mac OSX Snow Leopard on Cocoa minimal gives the string "Message".

However the documentation says that it shouldn't be used by the client code.

[vadz]

I have no idea where does "Message" come from but the comment in this function does say that it intentionally returns an empty string under OS X. I don't see why would this be useful behaviour though. It seems we should return

CFStringGetNameOfEncoding(CFStringGetSystemEncoding())

from there, shouldn't we?

[oneeyeman]

Vadim,

I think you are wrong.

I don't know much but it seems that according to  https://developer.apple.com/library/mac/#documentation/CoreFoundation/Reference/CFStringRef/Reference/reference.html

an application needs to call GetApplicationTextEncoding().

[vadz]

I don't believe we need to use GetApplicationTextEncoding() here but wx API is insufficient here anyhow, we need to have more precise functions. For now returning the encoding corresponding to the user's preferred language seem to be consistent with GetACP() under Windows (which is itself probably wrong however...).

[oneeyeman]

I tried to make a patch for Vadim's suggestion, but failed.

I will leave it for someone who is more familiar with wxCocoa internals.

[oneeyeman]

Ticket implementation

[oneeyeman]

Attached please find the implementation suggested by Vadim.

Tested on Cocoa build against 10.6 SDK.

On my Mac it returns "Western (Mac OS Roman)".

[VZ]

(In [72985]) Implement wxLocale::GetSystemEncodingName() for wxOSX.

Use CFStringGetNameOfEncoding() to get the canonical name of the encoding from
OS X itself.

Closes #2571.