Changes between Version 1 and Version 2 of Ticket #18736, comment 15


Ignore:
Timestamp:
Apr 27, 2020, 10:18:54 PM (12 months ago)
Author:
pb101
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18736, comment 15

    v1 v2  
    66All my commits are still here: https://github.com/PBfordev/wxWidgets/commits/dirdialog
    77
    8 I wonder about support for the new  wxDirDialog styles for other implementations, notably the generic and Qt one? These (or at least the generic one) do not have support all the flags the native implementations do?
     8I wonder about support for the new `wxDirDialog` styles for other implementations, notably the generic and Qt one? These (or at least the generic one) do not have to support all the flags the native implementations do?
    99
    10 Regarding updating `wxFileDialog` to match `wxDirDialog` API. I think that should be done in a separate PR. BTW, if the APIs between the two should be very similar; how comes that `wxDirDialog` has an option for showing hidden file while `wxFileDialog` has not?
     10Regarding updating `wxFileDialog` to match `wxDirDialog` API. I think that should be done in a separate PR. BTW, if the APIs between the two should be very similar; how comes that `wxDirDialog` has an option for showing hidden items while `wxFileDialog` has not?
    1111
    1212'''@Ian'''
    1313How should we proceed next regarding GIT? Once the changes I made are reviewed and finalized, my commits should be squashed together and a PR against your branch made? I know next to nothing about GIT...
    14