Changes between Initial Version and Version 1 of Ticket #18736, comment 13


Ignore:
Timestamp:
Apr 26, 2020, 9:53:09 PM (12 months ago)
Author:
pb101
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18736, comment 13

    initial v1  
    22Just for the record, on MSW `wxFileDialog` returns the file/path which is sorted as the first among the selected items based on how the items were displayed (it can be sorted by name, date, size etc.) in the dialog. I.e., it does not reflect the order the user selected the items, which can be seen in the "File Name" edit control below the list. I do not use any desktop OS besides Windows, so I do not know what happens on GTK/OSX/Qt...
    33
    4 When the check for `wxDD_MULTIPLE` in `wxDirDialog::GetPath()` fails, what should be returned: an empty string or a path? Currently it returns the path of the first selected item in MSW (see above) and of the last item in GTK and OSX?
     4When the check for `wxDD_MULTIPLE` in `wxDirDialog::GetPath()` fails, what should be returned: an empty string or a path? Currently it returns the path of the first item in MSW (see above) and of the last item in GTK and OSX?
    55----
    66
    7 == `wxDD_CHANGE_DIR` an `wxDD_MULTIPLE` incompatibility ==
     7== `wxDD_CHANGE_DIR` and `wxDD_MULTIPLE` incompatibility ==
    88I think the best way to check for this would be in `wxDirDialogBase::Create()`. The question is: Should the failed check return `false`? I assume returning `false` means the dialog will not be displayed? If this is too "harsh", `Create()` could still return `true` and the incompatibility must be handled also in the platform-specific code; I already do that in MSW, will revert if needed. I suppose Vadim knows how to generally handle such situations in wxWidgets codebase and will tell us what to do.
    99----