Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#18347 closed defect (fixed)

In gtk+3 wxASSERT_DLG's backtrace section is too compact

Reported by: dghart Owned by: Artur Wieczorek <artwik@…>
Priority: normal Milestone:
Component: wxGTK Version: dev-latest
Keywords: gtk+3 assert backtrace Cc:
Blocked By: Blocking:
Patch: no

Description

In gtk+3 builds of both wx3.0.4 and git HEAD, when the backtrace section of wxASSERT_DLG is opened it doesn't expand far enough vertically. This happens both in debian 9's 3.22.11 (LXDE) and a default install of ubuntu 18.10 (gtk+ 3.24.1, gnome shell). The attached screenshots show an assert dialog in 'minimal' and the difference from gtk+2.

Were this wx code I'd blame a missing sizer flag, but wxASSERT_DLG uses gtk+ direct.

Attachments (5)

wxAssertDlgGtk3.png download (35.1 KB) - added by dghart 18 months ago.
wxAssertDlgGtk3Expanded.png download (36.3 KB) - added by dghart 18 months ago.
wxAssertDlgUbuntu.png download (32.4 KB) - added by dghart 18 months ago.
wxAssertDlgGtk2.png download (45.3 KB) - added by dghart 18 months ago.
minimal.diff download (459 bytes) - added by dghart 18 months ago.

Download all attachments as: .zip

Change History (12)

Changed 18 months ago by dghart

Changed 18 months ago by dghart

Changed 18 months ago by dghart

Changed 18 months ago by dghart

Changed 18 months ago by dghart

comment:1 Changed 18 months ago by vadz

Unfortunately I don't know how does GtkExpander work that well neither, so any help with debugging the code in src/gtk/assertdlg_gtk.cpp would be welcome.

comment:2 Changed 18 months ago by Artur Wieczorek <artwik@…>

  • Owner set to Artur Wieczorek <artwik@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 775b9865/git-wxWidgets:

Fix setting minimum height of backtrace window in GtkAssertDialog

Minimum height needs to be set for the entire backtrace window
not for its child tree view.

Closes #18347.

comment:3 Changed 18 months ago by Artur Wieczorek <artwik@…>

In 775b9865/git-wxWidgets:

Fix setting minimum height of backtrace window in GtkAssertDialog

Minimum height needs to be set for the entire backtrace window
not for its child tree view.

Closes #18347.

comment:4 Changed 18 months ago by Paul Cornett <paulcor@…>

In 40c81a6a4/git-wxWidgets:

Fix minimum height of backtrace window in wxGTK assert dialog

For GTK3 < 3.10, see #18347

comment:5 Changed 18 months ago by Paul Cornett <paulcor@…>

In 40c81a6a4/git-wxWidgets:

Fix minimum height of backtrace window in wxGTK assert dialog

For GTK3 < 3.10, see #18347

comment:6 Changed 18 months ago by Paul Cornett <paulcor@…>

In a28e138b1/git-wxWidgets:

Fix minimum height of backtrace window in wxGTK3 assert dialog

See #18347
(backport of 40c81a6a4af4adb4c749a7884875fa934095f0a7)

comment:7 Changed 18 months ago by Paul Cornett <paulcor@…>

In a28e138b1/git-wxWidgets:

Fix minimum height of backtrace window in wxGTK3 assert dialog

See #18347
(backport of 40c81a6a4af4adb4c749a7884875fa934095f0a7)

Note: See TracTickets for help on using tickets.