Opened 3 months ago

Closed 3 months ago

#16383 closed enhancement (fixed)

choicdgg.cpp clean up

Reported by: troelsk Owned by: VZ
Priority: normal Milestone:
Component: GUI-generic Version: dev-latest
Keywords: wxChoice Cc:
Blocked By: Blocking:
Patch: yes

Description

  • Remove apparantly unused #include's (more can probably be removed)
  • Remove ConvertWXArrayToC helper function, just use the available dialog class ctor's instead (alternatively the wxCArrayString class could be used in place of ConvertWXArrayToC).
  • Remove unnecessary temporary variables.
  • Indentation adjustments.

Attachments (1)

choicdgg.cpp.patch download (9.0 KB) - added by troelsk 3 months ago.

Download all attachments as: .zip

Change History (2)

Changed 3 months ago by troelsk

comment:1 Changed 3 months ago by VZ

  • Owner set to VZ
  • Resolution set to fixed
  • Status changed from new to closed

In 76930:

Remove unnecessary ConvertWXArrayToC() helper choice dialog code.

Just use the appropriate wxSingleChoiceDialog ctor directly.

Also some renamings/reformattings, but no other real changes.

Closes #16383.

Note: See TracTickets for help on using tickets.