Opened 2 years ago

Closed 2 years ago

#16266 closed defect (fixed)

Make translatable labels of colors and cursors in wxPropertyGrid

Reported by: awi Owned by: VZ
Priority: low Milestone:
Component: wxPropertyGrid Version: dev-latest
Keywords: label wxSystemColourProperty wxColourProperty wxCursorProperty Cc:
Blocked By: Blocking:
Patch: yes

Description

Some labels (for wxSystemColourProperty, wxColourProperty, wxCursorProperty) exposed via GUI are not currently translatable.
Patch to make them translatable is attached.

Attachments (2)

Translatable-labels-of-colors-and-cursors.patch download (4.0 KB) - added by awi 2 years ago.
Translatable labels of colors and cursors.
Another-fixes-to-wxPropertyGrid.patch download (1.3 KB) - added by awi 2 years ago.
Another fixes to wxPropertyGrid.

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by awi

Translatable labels of colors and cursors.

comment:1 Changed 2 years ago by VZ

  • Owner set to VZ
  • Resolution set to fixed
  • Status changed from new to closed

In 76558:

Make names of properties used in wxPropertyGrid translatable.

Use _() around these user-visible strings, not wxT().

Closes #16266.

comment:2 Changed 2 years ago by VZ

In 76562:

(The changeset message doesn't reference this ticket)

Changed 2 years ago by awi

Another fixes to wxPropertyGrid.

comment:3 Changed 2 years ago by awi

  • Resolution fixed deleted
  • Status changed from closed to reopened

Some runtime errors (memory access violation caused by NULL pointers) can be observed when wxEnumProperty is created in the new way.
Patch fixing this issue is attached.

comment:4 Changed 2 years ago by vadz

Thanks a lot for testing and fixing this!

comment:5 Changed 2 years ago by VZ

  • Resolution set to fixed
  • Status changed from reopened to closed

In 76569:

Fix bugs in wxEnumProperty introduced by r76562.

The compilation fixes introduced run-time fixes due to not account for the use
of NULL pointers (which are not accepted as choices cache but are accepted as
choices values, go figure).

Closes #16266.

Note: See TracTickets for help on using tickets.