Opened 2 years ago

Closed 2 years ago

#16154 closed enhancement (fixed)

add wxGraphicsRenderer::GetName

Reported by: aasselin Owned by: VZ
Priority: normal Milestone: 3.1.0
Component: GUI-all Version:
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

this patch adds wxGraphicsRenderer::GetName for Cairo/CoreGraphics/GDI+ imeplementations

Attachments (2)

graphics-getname.patch download (3.8 KB) - added by aasselin 2 years ago.
graphics-getname-getversion.patch download (5.5 KB) - added by aasselin 2 years ago.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by aasselin

comment:1 Changed 2 years ago by aasselin

in fact I wonder if I should not include the version of the library (being the OS version for GDI+ / CoreGraphics, and Cairo version for Cairo), as the behavior of the renderer may not be the same... or should I add as well wxGraphicsRenderer::GetVersionString() ?

comment:2 Changed 2 years ago by vadz

  • Milestone set to 3.1.0
  • Status changed from new to confirmed

Thanks, just two minor comments:

  1. We've recently added wxOVERRIDE, could you please use it for the overridden methods?
  2. Is it really a good idea to use "+" in the string meant for the file names? Maybe it should return "gdiplus"? Generally speaking, if it's not fit for the human consumption anyhow, why capitalize them? I'd go with "cairo" and "cg" then (and maybe add GetDisplayName() later if we really need it).

TIA!

Changed 2 years ago by aasselin

comment:3 Changed 2 years ago by aasselin

1 and 2, OK, I had to add GetVersion as well, to let the drawing tests know about which version of the renderer they use.

comment:4 Changed 2 years ago by VZ

  • Owner set to VZ
  • Resolution set to fixed
  • Status changed from confirmed to closed

In 76380:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.