Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#16042 closed defect (fixed)

Drag & Drop accepts wrong data format on windows 7 x64

Reported by: jwiesemann Owned by:
Priority: critical Milestone:
Component: wxMSW Version:
Keywords: drag drop data format Cc:
Blocked By: Blocking:
Patch: yes

Description

Drag and Drop with 32 bit application (MSW debug build) on windows 7 64 bit accepts all data formats.

Though wxIDropTarget::DragEnter correctly sets the *pdwEffect to DROPEFFECT_NONE the function wxIDropTarget::DragOver is called by windows. And thus the wxDropTarget::OnDragOver is called with an invalid data type!

The code in 2.8.10 used an early return and didn't call any other functions when the data format wasn't accepted. Changing the current code back to this restores old behavior.

See patch.

Attachments (1)

droptgt.cpp.patch download (1.9 KB) - added by jwiesemann 7 months ago.
Patch for MSW drag & drop

Download all attachments as: .zip

Change History (3)

Changed 7 months ago by jwiesemann

Patch for MSW drag & drop

comment:1 Changed 7 months ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [76076]) Don't accept data in unsupported format in wxMSW dnd code.

We wrongly pretended to accept the data in formats which we didn't actually
accept and showed misleading cursors to the user.

Fix this by partially reverting some of the changes of r72668 (see #14697).

Closes #16042.

comment:2 Changed 7 months ago by VZ

(In [76078]) Don't accept data in unsupported format in wxMSW dnd code.

We wrongly pretended to accept the data in formats which we didn't actually
accept and showed misleading cursors to the user.

Fix this by partially reverting some of the changes of r72668 (see #14697).

Closes #16042.

Note: See TracTickets for help on using tickets.