Opened 8 months ago

Closed 4 months ago

Last modified 4 months ago

#15930 closed defect (wontfix)

GTK: dnd return code is not set for Drop event

Reported by: R.U.10 Owned by:
Priority: normal Milestone:
Component: wxGTK Version: dev-latest
Keywords: Cc: nerijus@…
Blocked By: Blocking:
Patch: yes

Description

Under GTK, the return code is defined during the Drag Over operation and not for the Drop event. It is currently impossible for the Drag source to know if the Drop operation on the target has failed or succeeded.
If some data are dragged over a suitable destination but if the Drop operation fails, the Drop Source gets back a return code that indicates that the Drop operation has succeeded.

Attachments (1)

GTK_Drop_status.patch download (1.8 KB) - added by R.U.10 8 months ago.

Download all attachments as: .zip

Change History (9)

Changed 8 months ago by R.U.10

comment:1 Changed 8 months ago by vadz

  • Resolution set to port to stable
  • Status changed from new to portneeded

Thanks! I'm not so sure of my understanding of GTK+ dnd to apply this to 3.0 immediately, but if no problems are found on the trunk with this patch, it should be backported there too later.

comment:2 Changed 8 months ago by VZ

  • Resolution changed from port to stable to fixed
  • Status changed from portneeded to closed

(In [75745]) Correctly detect cancelled drag-and-drop operations in wxGTK.

The status of the drop operation wasn't propagated back to the initiator of
drag and drop, so failing to drop data over a possibly accepting recipient
could result in wrong behaviour and even data loss.

Closes #15930.

comment:3 Changed 8 months ago by PC

(In [75749]) build fix for GTK3, see #15930

comment:4 Changed 8 months ago by pcor

  • Resolution changed from fixed to port to stable
  • Status changed from closed to portneeded

comment:5 Changed 7 months ago by nerijus

This patch breaks message moving in Mahogany and wxGTK. See http://thread.gmane.org/gmane.mail.mahogany.devel/3730/focus=3732 for more info.

comment:6 Changed 7 months ago by nerijus

  • Cc nerijus@… added

comment:7 Changed 4 months ago by vadz

  • Resolution changed from port to stable to wontfix
  • Status changed from portneeded to closed

Actually the problem can be seen in the dnd sample too, dragging the text to the zone accepting text drops now results in "Drag result: Nothing" being shown in the status bar which is clearly wrong, so I'm reverting this patch.

I'd need to have an example of what exactly doesn't work correctly without it as I do see "Drag result: Cancelled" just fine in the dnd sample, so I'm not sure what has to be fixed, exactly.

comment:8 Changed 4 months ago by VZ

In 76649:

Revert "Correctly detect cancelled drag-and-drop operations in wxGTK."

This reverts r75745 (and r75749 fixing a minor problem in it) as this change
broke the reporting of the result of the drag and drop operation instead of
fixing it.

See #15930.

Note: See TracTickets for help on using tickets.