Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#15888 closed defect (fixed)

[PATCH] Fix potential derference of invalid interator in src/common/tarstrm.cpp

Reported by: ettl.martin Owned by:
Priority: normal Milestone:
Component: GUI-all Version: dev-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

Please review the attached patch, it fixes a potential dereference of an invalid iterator in src/common/tarstrm.cpp.

It is more clever to FIRST check if the iterator is valid and then dereference it.

Best regards and many thanks

Martin Ettl

Attachments (1)

derefInvalidIterator.patch download (565 bytes) - added by ettl.martin 3 months ago.
fix

Download all attachments as: .zip

Change History (3)

Changed 3 months ago by ettl.martin

fix

comment:1 Changed 3 months ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [75641]) Fix possible crash in TAR header parsing code.

Check that the iterator is valid before using its value, otherwise the
validity check was useless.

Closes #15888.

comment:2 Changed 3 months ago by VZ

(In [75642]) Fix possible crash in TAR header parsing code.

Check that the iterator is valid before using its value, otherwise the
validity check was useless.

Closes #15888.

Note: See TracTickets for help on using tickets.