Opened 3 months ago

Closed 3 months ago

#15877 closed defect (fixed)

PropertyGridManager does break the changes with Freeze/Traw

Reported by: Hanmac Owned by:
Priority: normal Milestone:
Component: wxPropertyGrid Version: dev-latest
Keywords: Frozen Cc:
Blocked By: Blocking:
Patch: yes

Description

in Changes Since WxWidgets 2.8 it says:

wxWindow::Freeze/Thaw() are not virtual any more, if you overrode them in your code you need to override DoFreeze/Thaw() instead now.

PropertyGrid & PropertyGridManager still does it not, is that on purpose or is that a bug?

if its a bug i added a patch for that

Attachments (3)

propdridmanager_frozen.patch download (1.7 KB) - added by Hanmac 3 months ago.
propdrid_frozen.patch download (7.3 KB) - added by Hanmac 3 months ago.
propgridpagestate_frozen.patch download (505 bytes) - added by Hanmac 3 months ago.

Download all attachments as: .zip

Change History (4)

Changed 3 months ago by Hanmac

Changed 3 months ago by Hanmac

Changed 3 months ago by Hanmac

comment:1 Changed 3 months ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [75640]) Override Do{Freeze,Thaw}() instead of {Freeze,Thaw}() in wxPropGrid code.

{Freeze,Thaw}() themselves are not virtual any more, so overriding them
doesn't really work and it is unnecessary to reimplement the reference
counting already done by the base class anyhow, so override the DoXXX()
versions instead.

Closes #15877.

Note: See TracTickets for help on using tickets.