#15814 closed defect (fixed)

WXWIN_COMPATIBILITY_3_0 0 build errors

Reported by: johnr Owned by: vadz
Priority: normal Milestone:
Component: build Version: dev-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

defs.h enum wxDeprecatedGUIConstants contains many values that are needed in font.h

With WXWIN_COMPATIBILITY_3_0 0 build stops with many warnings from font.h mainly from enum wxFontFamily. The first is
wxFONTFAMILY_DEFAULT = wxDEFAULT,

Change History (2)

comment:1 Changed 12 months ago by vadz

  • Owner set to vadz
  • Status changed from new to accepted

I'll fix this, thanks.

comment:2 Changed 12 months ago by VZ

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [75565]) Just deprecate but don't schedule for removal wxNORMAL and friends.

Deprecate the use of the old untyped constants but don't schedule them from
removal in a future wx version by removing "#if WXWIN_COMPATIBILITY_3_0" tests
around their definition and use. Provoking deprecation warnings in the code
using these constants is worth it as they are unclear and it's easy to make
mistakes when using them, but breaking this code compilation outright can't be
justified -- even in the future.

Also use more informational wxDEPRECATED_MSG() instead of a simple
wxDEPRECATED() as it might not be obvious at all how should the code be
updated exactly.

Finally, avoid the use of deprecated constants inside the library itself.

As a side effect, this closes #15814.

Note: See TracTickets for help on using tickets.