Opened 4 months ago

Closed 3 months ago

#15762 closed enhancement (fixed)

Add missing events to OSX Cocoa

Reported by: oneeyeman Owned by: disc
Priority: normal Milestone: 3.0.1
Component: wxOSX-Cocoa Version: dev-latest
Keywords: combobox events simple Cc:
Blocked By: Blocking:
Patch: yes

Description

Hi,
This patch adds to missing events to combo box on Cocoa: wxEVT_COMBOBOX_DROPDOWN and wxEVT_COMBOBOX_CLOSEUP.
Patch tested on OSX Snow Leopard (10.6) with gcc 4.2.
Documentation is also updated.

Please apply.

Attachments (1)

patch.diff download (2.8 KB) - added by oneeyeman 4 months ago.
Implementation

Download all attachments as: .zip

Change History (11)

Changed 4 months ago by oneeyeman

Implementation

comment:1 Changed 4 months ago by oneeyeman

  • Milestone set to 3.0.1
  • Type changed from defect to enhancement

comment:2 Changed 4 months ago by disc

  • Owner set to disc
  • Status changed from new to accepted

comment:3 Changed 4 months ago by oneeyeman

Dimitri,
Do you want me to do the same for Carbon part?

comment:4 Changed 4 months ago by disc

Sure, sounds great! I'll commit both together once it's there. If you face problems with it just let me know and I'll only apply it for Cocoa.

comment:5 Changed 4 months ago by oneeyeman

Dimitri,
Please apply.
I don't know when I will have time to work on this.

Besides Carbon is going away and currently widgets sample is crashing on Carbon build.

comment:6 Changed 3 months ago by DS

(In [75783]) Added support for wxEVT_COMBOBOX_DROPDOWN and wxEVT_COMBOBOX_CLOSEUP events to wxOSX/Cocoa.

See #15762.

comment:7 Changed 3 months ago by disc

  • Status changed from accepted to infoneeded

I finally applied the (slightly modified) patch for trunk. I don't know for certain if it can be backported to 3.0 so I'm keeping the ticket open for now. I modified abicheck.sh for OS X and it didn't find any problems but I had to remove some flags also (-D and --defined-only).

Regarding the widgets sample crashing with the Carbon build: if you're still seeing this then please open a ticket for it. I'm not seeing the problem here unfortunately (r75725) .

comment:8 Changed 3 months ago by vadz

  • Status changed from infoneeded to accepted

The patch is certainly ABI-compatible as it doesn't touch the headers at all. And the changes seem safe to me (i.e. no danger of a crash as all pointers are checked), so I think it can indeed be backported.

comment:9 Changed 3 months ago by vadz

  • Resolution set to port to stable
  • Status changed from accepted to portneeded

comment:10 Changed 3 months ago by DS

  • Resolution changed from port to stable to fixed
  • Status changed from portneeded to closed

(In [75790]) Added support for wxEVT_COMBOBOX_DROPDOWN and wxEVT_COMBOBOX_CLOSEUP events to wxOSX/Cocoa.

Backport of r75783.

Closes #15762.

Note: See TracTickets for help on using tickets.