#15598 closed build error (fixed)

ICC complains: non-POD (Plain Old Data) class type passed through ellipsis (.\src\msw\crashrpt.cpp(229): warning #1595)

Reported by: ghostvoodooman Owned by:
Priority: low Milestone:
Component: base Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

Greetings,

config: MSVC 2013 RC, ICC, unicode, x86, no modifications to setup.h .

While compiling with the latest ICC 14.x I get following warning:

7>..\..\src\msw\crashrpt.cpp(229): warning #1595: non-POD (Plain Old Data) class type passed through ellipsis
7>            Output(wxT("%s"), wxDbgHelpDLL::GetErrorMessage().c_str());
7>                              ^
7>  

As this situation could rarely come in, since dbg help DLL is always there, I consider this as low-priority.

But what if...

Is this argument okay, so this is a false-positive? Or is there ellipsis rules regarding POD violation?

best,
vdm
.

Change History (1)

comment:1 Changed 10 months ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [75060]) Fix passing wxCStrData to a vararg function.

This doesn't work with simple vararg functions and the real solution would be
to use WX_DEFINE_VARARG_FUNC for wxCrashReport::Output() but for now just add
a cast to make the code compile and work with minimal changes.

Closes #15598.

Note: See TracTickets for help on using tickets.