#15563 closed defect (fixed)

PNG broken by $Id removal

Reported by: ojwb Owned by:
Priority: normal Milestone: 3.0.0
Component: documentation Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

r74602 removed $Id from a huge number of files, but one of these was a PNG file which just happened to contain the string $Id:

docs/doxygen/images/logo_osxleopard.png

You can see the result of this as a broken OS X logo here:

http://docs.wxwidgets.org/3.0.0/page_port.html

I can't usefully attach a patch for a binary file, but this file should be reverted to how it was before r74602.

I've checked all the files changed by r74602 with both perl's -B operator and the file command, and the only other binary file I can see in the list is:

samples/internat/it/internat.mo

I'm not sure if that's harmful to change a .mo file with a simple search and replace or not, but for safety this should probably get regenerated from the corresponding .po file.

P.S. 3.0.0-rc1 doesn't seem to be in trac's list of versions, so I've set this as being in 2.9-svn.

Change History (3)

comment:1 Changed 15 months ago by bpetty

  • Resolution set to fixed
  • Status changed from new to closed

Logo removed as per #15564.

comment:2 Changed 15 months ago by bpetty

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for the issue with samples/internat/it/internat.mo, I didn't actually look at that one, and it'd be great if someone else did.

comment:3 Changed 15 months ago by VZ

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [74973]) Undo the changes to a sample message catalog by "$Id" removal.

Revert the changes of r74602 to a binary file.

Closes #15563.

Note: See TracTickets for help on using tickets.