Opened 6 years ago

Last modified 6 years ago

#15453 confirmed defect

Broken --with-sdl --with-gtk on Mac OS X

Reported by: mojca Owned by:
Priority: low Milestone:
Component: build Version: 2.9.5
Keywords: Cc: kolya.kosenko@…
Blocked By: Blocking:
Patch: no

Description

If I try to compile GTK on Mac OS X with --with-sdl, it fails.

I have found a patch somewhere. I'm not sure where (maybe on Fink's site? http://www.finkports.info/ports/x11/wxgtk2.8.html) and what it does, but it solves the problem for me.

I would be grateful if someone could look into this and patch wxWidgets, either with the attached patch or with something else that seems more appropriate.

Attachments (1)

patch-sdl.diff download (3.0 KB) - added by mojca 6 years ago.
A patch for Makefile.in to make --with-sdl work with GTK on Mac OS X

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by mojca

A patch for Makefile.in to make --with-sdl work with GTK on Mac OS X

comment:1 Changed 6 years ago by vadz

  • Milestone 3.0 deleted
  • Patch unset
  • Priority changed from normal to low
  • Status changed from new to confirmed
  • Summary changed from Broken --with-sdl --with-gtk on Mac OS X (patch for Makefile.in) to Broken --with-sdl --with-gtk on Mac OS X

Unfortunately the patch can't be applied as is, it's a generated file. Besides, I'm almost sure this is going to break wxOSX build as we'd have duplicate wxSound implementations in it.

What we should do instead would be to:

  1. Modify build/bakefiles/files.bkl to include this file under OS X too (or maybe even under all platforms if we need it for wxGTK under Windows too?).
  2. Add a check for !defined(__WXMAC__) || defined(__WXCOCOA__) to src/unix/sound_sdl.cpp to prevent its contents from being compiled if there is a native implementation.

comment:2 Changed 6 years ago by kosenko

  • Cc kolya.kosenko@… added

comment:3 Changed 6 years ago by mojca

Sadly I don't have sufficient background to know/understand what exactly would have to be done for a proper patch, but just to make sure that I understand the issue:

  • Does/should --with-sdl make any difference on __WXMAC__ at all? What about on GTK-based installation under Mac?
  • Are you suggesting to include the file, but making sure that it would use the native libraries rather than the ones provided SDL?

Thank you.

Note: See TracTickets for help on using tickets.