#15443 closed build error (fixed)

WXINTL_NO_GETTEXT_MACRO not working with 2.9.5

Reported by: SameProblem Owned by:
Priority: low Milestone: 3.0.0
Component: GUI-all Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

Same problem as discussed here:
http://trac.wxwidgets.org/ticket/10132

just different files:

http://svn.wxwidgets.org/viewvc/wx/wxWidgets/trunk/interface/wx/filename.h?view=markup&pathrev=74639

*/
665 	wxString
666 	GetHumanReadableSize(const wxString& failmsg = _("Not available"),
667 	int precision = 1,
668 	wxSizeConvention conv = wxSIZE_CONV_TRADITIONAL) const;
669 	
670 	static wxString
671 	GetHumanReadableSize(const wxULongLong& bytes,
672 	const wxString& nullsize = _("Not available"),
673 	int precision = 1,
674 	wxSizeConvention conv = wxSIZE_CONV_TRADITIONAL);

shoudl use wxGetTranslation instead of _

Also same issue in these header files:
include\wx\msw\ole\oleutils.h
include\wx\msw\private\fswatcher.h
include\wx\prntbase.h
include\wx\richmsgdlg.h
include\wx\richtext\richtextbuffer.h
include\wx\richtext\richtextimagedlg.h
include\wx\richtext\richtextprint.h
include\wx\richtext\richtextstyledlg.h
include\wx\sizer.h
include\wx\unix\pipe.h
include\wx\unix\private\fswatcher_kqueue.h
include\wx\xtiprop.h

Change History (2)

comment:1 Changed 13 months ago by vadz

  • Milestone set to 3.0
  • Priority changed from normal to low
  • Status changed from new to confirmed

If someone could do these (trivial) changes, test that they work and submit a patch with them, it would be great. TIA!

comment:2 Changed 13 months ago by VZ

  • Resolution set to fixed
  • Status changed from confirmed to closed

(In [74812]) Use wxGetTranslation() instead of _() in the public headers.

This allows the code in them to compile even when WXINTL_NO_GETTEXT_MACRO is
defined.

Closes #15443.

Note: See TracTickets for help on using tickets.