Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#15375 closed defect (fixed)

Generic wxSpinCtrl should not send text command event

Reported by: eco Owned by:
Priority: normal Milestone:
Component: GUI-generic Version: 2.9.5
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

MSW got a fix for this (#13589) but it still happens with the generic control on wxOSX.

In the attached patch I opted to just switch the SetValue to ChangeValue to prevent the event from firing.

Attachments (1)

spinctrl-no-creation-event.patch download (441 bytes) - added by eco 9 months ago.
Do not send text command event during generic wxSpinCtrl creation

Download all attachments as: .zip

Change History (3)

Changed 9 months ago by eco

Do not send text command event during generic wxSpinCtrl creation

comment:1 Changed 9 months ago by juliansmart

  • Resolution set to fixed
  • Status changed from new to closed

Applied, thanks.

comment:2 Changed 9 months ago by VZ

(In [74630]) Add test for absence of events from wxSpinCtrlDouble ctor.

Run the same NoEventsInCtor() test as we already had for wxSpinCtrl for
wxSpinCtrlDouble as well.

Unfortunately currently there is no way to reuse the tests between these two
classes, we should refactor these test cases to use a common
SpinCtrlTestCaseBase<T> base class.

See #15375 which fixed the underlying bug.

Note: See TracTickets for help on using tickets.