Opened 14 months ago

Closed 8 months ago

#15324 closed enhancement (fixed)

Added wxHtmlWindow::SetDefaultHTMLCursor

Reported by: jamarr81 Owned by:
Priority: low Milestone:
Component: wxHtml Version: 2.9.4
Keywords: default html cursor Cc:
Blocked By: Blocking:
Patch: yes

Description

I needed the ability to dynamically change the default HTML cursor prior to, and after, any HTML windows where created.

In addition, the mechanics of wxHtmlWindow::GetDefaultHTMLCursor were inconsistent in respect to creating a cursor when none existed in that it would dynamically create the link/text cursor, but instead use *wxSTANDARD_CURSOR for the default cursor. I modified this function to mimic the behavior for the link/text cursor, such that deleting an existing instance of the default cursor in wxHtmlWindow::SetDefaultHTMLCursor would be possible (without crashing) after calling wxHtmlWindow::getDefaultHTMLCursor(HTMLCursor_Default).

Attachments (3)

wxHtmlWindow_SetDefaultHTMLCursor.patch download (2.7 KB) - added by jamarr81 14 months ago.
wxHtmlWindow_SetDefaultHTMLCursor_docs.patch download (795 bytes) - added by jamarr81 14 months ago.
wxHtmlWindow_SetDefaultHTMLCursor_doxygen.patch download (1.3 KB) - added by jamarr81 13 months ago.
simple patch for doxygen as requested

Download all attachments as: .zip

Change History (7)

Changed 14 months ago by jamarr81

comment:1 Changed 14 months ago by vadz

  • Keywords docs-needed added
  • Priority changed from normal to low
  • Status changed from new to confirmed

Could you please add the documentation for the new public SetDefaultHTMLCursor() method to interface/wx/html/htmlwin.h?

TIA!

Changed 14 months ago by jamarr81

Changed 13 months ago by jamarr81

simple patch for doxygen as requested

comment:2 Changed 9 months ago by jamarr81

  • Keywords html added; docs-needed removed

comment:3 Changed 8 months ago by vadz

Thanks, will apply soon.

Just a small request for any next patches: please don't use hard TABs in wxWidgets sources, they have to be manually removed when applying. TIA!

comment:4 Changed 8 months ago by VZ

  • Resolution set to fixed
  • Status changed from confirmed to closed

(In [75398]) Add wxHtmlWindow::SetDefaultHTMLCursor().

This allows to change the cursors used by any HTML windows, before creating
them.

Closes #15324.

Note: See TracTickets for help on using tickets.