#15190 closed defect (fixed)

wxRichTextTable::ClearTable doesn't reset the col/row counts

Reported by: dghart Owned by:
Priority: normal Milestone: 2.9.5
Component: wxRichText Version: stable-latest
Keywords: wxRichTextTable::ClearTable Cc:
Blocked By: Blocking:
Patch: yes

Description

wxRichTextTable::ClearTable is used internally in only two places, neither of which care whether m_colCount and m_rowCount are reset. However future uses, and user code, might reasonably assume that they are.

The attached patch does this, and tests for it in RichTextCtrlTestCase.

Attachments (1)

patch.diff download (940 bytes) - added by dghart 15 months ago.

Download all attachments as: .zip

Change History (2)

Changed 15 months ago by dghart

comment:1 Changed 14 months ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [74057]) Reset row and columns count in wxRichTextTable::ClearTable().

No real changes, just update the internal variables in ClearTable() to avoid
inconsistent internal state, even if this doesn't seem to result in any
problems for now.

Closes #15190.

Note: See TracTickets for help on using tickets.