#15185 closed defect (fixed)

Make adding/deleting wxRichTextTable rows and columns undoable

Reported by: dghart Owned by:
Priority: normal Milestone: 2.9.5
Component: wxRichText Version: stable-latest
Keywords: wxRichTextTable undo Cc:
Blocked By: Blocking:
Patch: yes

Description

It's possible to add and delete columns and rows from a wxRichTextTable, but these procedures are not currently undoable. The attached richtextbuffer.diff (which depends on the previous reports in this series) implements this and can be seen working in the richtext sample diff.

I've also added a patch to RichTextCtrlTestCase which tests this series of wxRichTextTable patches.

Attachments (3)

wxrichtextbuffer.diff download (5.0 KB) - added by dghart 17 months ago.
richtext.diff download (13.4 KB) - added by dghart 17 months ago.
unittext.diff download (5.2 KB) - added by dghart 17 months ago.

Download all attachments as: .zip

Change History (6)

Changed 17 months ago by dghart

Changed 17 months ago by dghart

Changed 17 months ago by dghart

comment:1 Changed 17 months ago by juliansmart

Thanks for these. However I couldn't see where StoreObject is defined - did you add it to wxRichTextAction but forget to include the diff?

Thanks again!

comment:2 Changed 17 months ago by dghart

However I couldn't see where StoreObject is defined

It's in the #15084 patch, which needs to be applied first anyway.

Also, before applying this please consider #15086...

comment:3 Changed 17 months ago by juliansmart

  • Resolution set to fixed
  • Status changed from new to closed

Thanks, applied now, notwithstanding the nested table bug.

Note: See TracTickets for help on using tickets.