Opened 2 years ago

Closed 2 years ago

#15131 closed optimization (fixed)

Hide unused code

Reported by: kosenko Owned by:
Priority: normal Milestone:
Component: wxGTK Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

wxGetNameFromGtkOptionEntry() and struct _GOptionGroup is used only in wxGUIAppTraits::GetStandardCmdLineOptions() below of them. They can be hidden on non unix platforms.

Attachments (1)

gtk_hide_unix.diff download (887 bytes) - added by kosenko 2 years ago.

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by kosenko

comment:1 Changed 2 years ago by vadz

Don't we need to also add the corresponding #ifdef to include/wx/unix/apptrait.h? I.e.

  • include/wx/unix/apptrait.h

    a b class WXDLLIMPEXP_CORE wxGUIAppTraits : public wxGUIAppTraitsBase 
    6969
    7070#ifdef __WXGTK20__
    7171    virtual wxString GetDesktopEnvironment() const;
     72#ifdef __UNIX__
    7273    virtual wxString GetStandardCmdLineOptions(wxArrayString& names,
    7374                                               wxArrayString& desc) const;
     75#endif // __UNIX__
    7476#endif // __WXGTK20____
    7577
    7678#if defined(__WXGTK20__)

?

comment:2 Changed 2 years ago by kosenko

No, wxGUIAppTraits for wxGTK/Win32 is defined in include/wx/msw/apptrait.h

It would be nice to have wxGUIAppTraits::GetStandardCmdLineOptions() with Win32 GDK backend, but I'm not investigate at all if this method is applicable here.

comment:3 Changed 2 years ago by kosenko

Unfortunately wxGUIAppTraits both interface and implementation toss in many files.

comment:4 Changed 2 years ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [73764]) Don't use GetStandardCmdLineOptions() under non-Unix platforms.

The GTK+ standard options are only available under Unix.

Closes #15131.

Note: See TracTickets for help on using tickets.