wxFrameBase::ShouldUpdateMenuFromIdle() not guarded by #ifdef wxUSE_MENU, as its declaration is; iPhone build fails as a result
|Reported by:||ulrikp||Owned by:|
|Keywords:||iPhone Core wxFrameBase::ShouldUpdateMenuFromIdle()||Cc:|
thanks so much for your work on wxWidgets.
I tried compiling the wxosx_iphone from the Xcode project of the nightly build built on 2013-02-23. I am using XCode .
Here's the problem, which causes the wxosx_iphone Xcode project to fail to build.
In include/wx/frame.h, the static method of wxFrameBase:
is placed inside #if wxUSE_MENUS.
In src/common/framecmn.cpp, however, this method is placed outside of the
#if wxUSE_MENUS && wxUSE_STATUSBAR
thus causing Clang to fail, complaining that there is no declaration for wxFrameBase::ShouldUpdateMenuFromIdle() in wxFrameBase.
I attach a patch which should fix the problem.
Perhaps I am not building the iPhone port correctly, but it seems to me that even if that is the case, this method should be properly guarded by an #if.