Ticket #14974 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

right alt + key is unnecessarily intercepted

Reported by: maniek Owned by:
Priority: normal Milestone: 2.9.5
Component: WebView Version: 2.9-svn
Keywords: Cc:
Blocked By: Patch: no
Blocking:

Description

This is for webview on Windows

On some keyboard layouts you use right_alt+key to enter national characters. For example, right_alt+o gives "ó" in Polish-programmers layout.
Windows maps right alt to alt+ctrl in this keyboard layout.

Look at DocHostUIHandler::TranslateAccelerator : it blocks ctrl+o, which means that right alt+o will also be blocked.

I think the test in the abovementioned function should say:

if((GetKeyState(VK_CONTROL) & 0x8000 ) && !((GetKeyState(VK_MENU) & 0x8000 )){

Change History

Changed 4 months ago by maniek

  • version set to 2.9-svn
  • milestone set to 2.9.5

Changed 4 months ago by steve_lamerton

  • status changed from new to confirmed

Thanks for reporting this, I can confirm that it does indeed occur. I will commit the fix shortly.

Changed 4 months ago by SJL

  • status changed from confirmed to closed
  • resolution set to fixed

(In [73381]) When handling accelerators in wxWebView make sure that we do not block right-alt which can be mapped to alt + ctrl.

Fixes #14974.

Note: See TracTickets for help on using tickets.