Opened 5 years ago

Closed 5 years ago

#14933 closed optimization (fixed)

[patch] cleanup copy and paste code in src/html/helpwnd.cpp

Reported by: ettl.martin Owned by:
Priority: normal Milestone:
Component: wxHtml Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: yes


Please review the attached patch, which cleans up potential copy and pasted code in file src/html/helpwnd.cpp.

It removes a redundant initialization:

    wxBorder htmlWindowBorder = GetDefaultBorder();
    htmlWindowBorder = wxBORDER_THEME;

and converts it to

    wxBorder htmlWindowBorder = wxBORDER_THEME;

Best regards and many thanks

Martin Ettl

Attachments (1)

cleanup.patch download (458 bytes) - added by ettl.martin 5 years ago.
proposed patch

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by ettl.martin

proposed patch

comment:1 Changed 5 years ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [73315]) No changes, just remove unneeded variable initialization.

Don't initialize htmlWindowBorder in wxHtmlHelpWindow::Create() just to
overwrite it with another value on the next line.

Closes #14933.

Note: See TracTickets for help on using tickets.