Ticket #14933 (closed optimization: fixed)

Opened 5 months ago

Last modified 5 months ago

[patch] cleanup copy and paste code in src/html/helpwnd.cpp

Reported by: ettl.martin Owned by:
Priority: normal Milestone:
Component: wxHtml Version: 2.9-svn
Keywords: Cc:
Blocked By: Patch: yes
Blocking:

Description

Please review the attached patch, which cleans up potential copy and pasted code in file src/html/helpwnd.cpp.

It removes a redundant initialization:

    wxBorder htmlWindowBorder = GetDefaultBorder();
    htmlWindowBorder = wxBORDER_THEME;

and converts it to

    wxBorder htmlWindowBorder = wxBORDER_THEME;

Best regards and many thanks

Martin Ettl

Attachments

cleanup.patch download (458 bytes) - added by ettl.martin 5 months ago.
proposed patch

Change History

Changed 5 months ago by ettl.martin

proposed patch

Changed 5 months ago by VZ

  • status changed from new to closed
  • resolution set to fixed

(In [73315]) No changes, just remove unneeded variable initialization.

Don't initialize htmlWindowBorder in wxHtmlHelpWindow::Create() just to
overwrite it with another value on the next line.

Closes #14933.

Note: See TracTickets for help on using tickets.