Opened 6 years ago

Closed 6 years ago

#14908 closed optimization (fixed)

[PATCH] cleanup redundant reassignment of value in src/common/sizer.cpp

Reported by: ettl.martin Owned by:
Priority: normal Milestone:
Component: GUI-all Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: yes


Please review the attached patch. It cleans up the code in src/common/sizer.cpp and saves one redundant reassignment of a variable.

Best regards and many thanks

Martin Ettl

Attachments (1)

cleanup.diff download (624 bytes) - added by ettl.martin 6 years ago.
proposed patch

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by ettl.martin

proposed patch

comment:1 Changed 6 years ago by vadz

  • Resolution set to invalid
  • Status changed from new to closed

It's totally not obvious why is this assignment redundant, in fact I'm pretty sure it isn't.

comment:2 Changed 6 years ago by pcor

Maybe a little hard to tell because the function is gigantic, but the variable is never accessed again.

comment:3 Changed 6 years ago by vadz

  • Resolution invalid deleted
  • Status changed from closed to reopened

OK, I stand corrected, I indeed didn't notice this, sorry.

comment:4 Changed 6 years ago by VZ

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [73240]) Remove unnecessary variable assignment from wxBoxSizer::RecalcSizes().

The "delta" variable was assigned a value that was never used afterwards.

Closes #14908.

Note: See TracTickets for help on using tickets.