Ticket #14908 (closed optimization: fixed)

Opened 5 months ago

Last modified 5 months ago

[PATCH] cleanup redundant reassignment of value in src/common/sizer.cpp

Reported by: ettl.martin Owned by:
Priority: normal Milestone:
Component: GUI-all Version: 2.9-svn
Keywords: Cc:
Blocked By: Patch: yes
Blocking:

Description

Please review the attached patch. It cleans up the code in src/common/sizer.cpp and saves one redundant reassignment of a variable.

Best regards and many thanks

Martin Ettl

Attachments

cleanup.diff download (0.6 KB) - added by ettl.martin 5 months ago.
proposed patch

Change History

Changed 5 months ago by ettl.martin

proposed patch

Changed 5 months ago by vadz

  • status changed from new to closed
  • resolution set to invalid

It's totally not obvious why is this assignment redundant, in fact I'm pretty sure it isn't.

Changed 5 months ago by pcor

Maybe a little hard to tell because the function is gigantic, but the variable is never accessed again.

Changed 5 months ago by vadz

  • status changed from closed to reopened
  • resolution deleted

OK, I stand corrected, I indeed didn't notice this, sorry.

Changed 5 months ago by VZ

  • status changed from reopened to closed
  • resolution set to fixed

(In [73240]) Remove unnecessary variable assignment from wxBoxSizer::RecalcSizes().

The "delta" variable was assigned a value that was never used afterwards.

Closes #14908.

Note: See TracTickets for help on using tickets.