Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#14837 closed defect (fixed)

More compilation fixes after r72978

Reported by: dghart Owned by:
Priority: high Milestone: 2.9.5
Component: wxGTK Version: stable-latest
Keywords: compilation fix wxNOEXCEPT Cc:
Blocked By: Blocking:
Patch: yes

Description

Even after r72984, the r72978 wxNOEXCEPT changes break compilation using debian wheezy's gcc 4.7.1, as treectrl dtor definitions don't match their declarations. The patch fixes wxGTK and wxX11 builds, and there's a blind fix for any remaining wxGTK1 users.

Attachments (1)

wxNOEXCEPT.diff download (1.4 KB) - added by dghart 17 months ago.

Download all attachments as: .zip

Change History (4)

Changed 17 months ago by dghart

comment:1 Changed 17 months ago by vadz

  • Cc ghostvoodooman added

I'm afraid we may need to rethink this, I didn't realize that r72978 would result in breaking compilation of all user-defined classes deriving from wxTextCtrl. Unless there is some way around this, I'm going to revert all this, the benefit of this change is not nearly high enough to justify this breakage.

comment:2 Changed 17 months ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [72989]) More compilation fixes after wxNOEXCEPT introduction.

This is a temporary change, r72984 and the following changes (see #14826) will
probably be reverted soon anyhow, but for now at least fix wxGTK compilation.

Closes #14837.

comment:3 Changed 17 months ago by ghostvoodooman

  • Cc ghostvoodooman removed

no real changes: removed a Cc: me, I'm a subscriber of wx-dev and -commit list (noting this for future as well...).

Note: See TracTickets for help on using tickets.