Opened 6 years ago
Closed 6 years ago
#14822 closed defect (invalid)
wxHtmlLinkEvent and wxHtmlCellEvent: copy constructor missing
| Reported by: | tvb377 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | wxHtml | Version: | 2.9.4 |
| Keywords: | wxHtmlLinkEvent wxHtmlCellEvent | Cc: | |
| Blocked By: | Blocking: | ||
| Patch: | yes |
Description
AFAICS these classes should be given wxDECLARE_DYNAMIC_CLASS_NO_COPY
instead of NO_ASSIGN.
Given their member variables it seems to me an error to attempt to copy an instance of these classes.
I noticed this during LTO-linking with core,base static libs.
gcc then somehow (actually, I don't understand why, given the wx-#includes I'm using) emits an auto generated copy constructor for these classes.
After applying the attached changes wxWidgets (wxhtml) still compiles ok.
Attachments (1)
-
htmlwin.h.patch
(544 bytes) -
added by tvb377 6 years ago.
Download all attachments as: .zip
Change History (2)
Changed 6 years ago by tvb377
comment:1 Changed 6 years ago by vadz
- Resolution set to invalid
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
No, sorry, this can't be right. The copy ctor shouldn't be disabled (why?) and is actually used by Clone() so removing it should break the compilation, not fix it. Perhaps you've hit a bug in gcc but the code looks 100% correct to me and the change 100% wrong.