Opened 2 years ago

Closed 2 years ago

#14816 closed enhancement (fixed)

GetSizeFromTextSize() part 2 (wxMSW)

Reported by: mmarsan Owned by:
Priority: normal Milestone:
Component: GUI-all Version: stable-latest
Keywords: GetSizeFromTextSize GetBestSize Cc:
Blocked By: Blocking:
Patch: no

Description

I attach the second part:
wxTextCtrl, wxChoice, and wxComboBox for wxMSW.

It also fix wxGTK wxTextCtrl to treat wxBORDER_NONE flag.

Attachments (1)

GetSizeFromTextSize_part_2.patch download (8.9 KB) - added by mmarsan 2 years ago.

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by mmarsan

comment:1 Changed 2 years ago by VZ

(In [72952]) Handle wxBORDER_NONE in wxGTK wxTextCtrl::DoGetSizeFromTextSize().

Don't add margins for the controls without borders, they are not used in this
case.

See #14816.

comment:2 Changed 2 years ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [72954]) Implement DoGetSizeFromTextSize() for wxMSW wx{Choice,Combobox,TextCtrl}.

Refactor and improve the existing DoGetBestSize() implementations to use
DoGetBestSize().

Closes #14816.

Note: See TracTickets for help on using tickets.