wxGenericDirCtrl item data accessor

[troelsk]

Spare the users from wxDirItemData* casts.
Patch:
One const public method and, for internal use, a non-const private version.

[troelsk]

Trunk

[vadz]

I don't know this code at all but should we really expose this (undocumented) wxDirItemData? What can you do with it exactly?

I'm, of course, fine with applying the non-public part of the patch.

[troelsk]

Undocumented indeed, and looks somewhat unfinished. But this, the item data cast, is the only way to find out which items the user is clicking, from your Connect(),

Connect(GetTreeCtrl()->GetId(), wxEVT_COMMAND_TREE_SEL_CHANGED, wxTreeEventHandler(DirCtrl::OnTreeSelChange));

More:
 https://www.google.dk/search?q=wxGenericDirctrl+events

[vadz]

I really think there should be a separate control-specific event for this instead. But failing that, adding a simple accessor for a path from wxTreeItemId would IMHO still be preferable because wxDirItemData should really have been private in the first place.

[troelsk]

GetPath(wxTreeItemId)

[troelsk]

Ok, patch updated, with "a simple accessor for a path from wxTreeItemId"

I really think there should be a separate control-specific event for this instead

+1 Very much in favour

[vadz]

Replying to troelsk:

Ok, patch updated, with "a simple accessor for a path from wxTreeItemId"

Perfect, thanks!

I really think there should be a separate control-specific event for this instead

+1 Very much in favour

I'd apply any patches implementing this. I don't know this control at all, to be honest, but it just seems completely logical to have control-specific events for something as complex/high-level as this. TIA!

[VZ]

(In [72819]) Add wxDirCtrl::GetPath().

This allows to retrieve the directory being affected by wxTreeCtrl event.

Closes #14790.

[troelsk]

private GetItemData()

[troelsk]

Updated private GetItemData() patch

[VZ]

(In [72841]) No changes, just some cleanup in wxGenericDirCtrl code.

Use GetItemData() helper to only write a cast to wxDirItemData in this
function instead of repeating it many times.

See #14790.