incompatible change in r72707

[troelsk]

wxFileName::DirExists() used to drop the file name and do the check on the dir part only.
Patch: restore old behaviour

[troelsk]

Trunk

[VZ]

(In [72718]) Revert accidental incompatible change to wxFileName::DirExists().

The non-static version tests for the existence of the directory part of the
object only as is explicitly mentioned in the documentation, so do the test on
GetPath() and not GetFullPath() as we did since r72707.

Also add a unit test for this behaviour.

Closes #14771.

[troelsk]

There's a ticking bomb there, referencing a temp string object

const wxString& tempdir = wxFileName::GetTempDir();

[
 http://svn.wxwidgets.org/viewvc/wx/wxWidgets/trunk/tests/filename/filenametest.cpp?r1=72717&r2=72718&pathrev=72718
]

[csomor]

the const reference to the temp remains valid until it goes out of scope IIRC

[vadz]

Replying to csomor:

the const reference to the temp remains valid until it goes out of scope IIRC

Yes,  exactly.

[troelsk]

Ok thanks!