Bug with wxInfoBar close button on OSX

[swiss_kinkajou]

Since changeset 72474 there is a bug with wxInfoBar. The close button always appears on the top left part of the window, even when the wxInfoBar isn’t visible. Moreover, clicking on the button when the wxInfoBar is visible didn’t close the wxInfoBar.
This strange behavior is visible on the dialog sample.

My config options are :

../configure --enable-unicode --disable-monolithic --disable-shared  --with-osx_cocoa

[vadz]

Interesting... r72474 was supposed to be a completely neutral refactoring, I have no idea how could it have broken this. Are you quite sure about it, i.e. does just reverting this commit really fix the problem?

[swiss_kinkajou]

72473

[swiss_kinkajou]

72474

[swiss_kinkajou]

I just rebuild wxWidgets 72473 and 72474 side by side and in the 72473 the problem doesn’t occur.
I made two screenshots, in the first one (72473) there is no problem while in the second (72474) we see a strange close button (top left).

[VZ]

(In [72690]) Use the correct window as parent of wxInfoBar close button.

Fix breakage of r72474 that used the parent window instead of wxInfoBar itself
as the parent of its close button.

Closes #14750.

[vadz]

Sorry, I'm blind, I did break it in r72474. Hopefully it's fixed now, but I didn't test it yet, please reopen if it isn't.