#14749 closed defect (fixed)

wxWebviewIE - unregistering namespaces

Reported by: maniek Owned by:
Priority: normal Milestone: 2.9.5
Component: WebView Version:
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

The part In wxWebviewIE destructor that releases the ClassFactories is a bit clunky.

I propose to fix it with the attached (patch against 2.9.4, in trunk it is quite similar). This patch calls IInternetSession::UnregisterNamespace, instead of just calling Release() on the factories in m_factories list.

Note the added AddRef call - now there is matching number of AddRef/Release calls for each ClassFactory.

I can make 2.9.4 segfault, but the smallest testcase I can make involves quite a chunk of javascript, so I am not giving it here. The attached patch fixes it.

Attachments (1)

UnregisterNameSpace.patch download (1.9 KB) - added by maniek 22 months ago.
patch

Download all attachments as: .zip

Change History (2)

Changed 22 months ago by maniek

patch

comment:1 Changed 22 months ago by SJL

  • Resolution set to fixed
  • Status changed from new to closed

(In [72715]) Explicitly unregister custom wxWebViewIE namespaces when we are done with them. Also add a missing ClassFactory::AddRef.

Closes #14749

Note: See TracTickets for help on using tickets.