Bad wxAuiNotebook child position (theming problem ?)

[EmilienKia]

Hi all,

This is a little problem of theming with wxAuiNotebook on Linux (wxAuiGtkTabArt): child windows are not well placed relative to theme. They use all available width without letting space to border theme.

The problem is visible on screenshots (AUI sample versus Pluma/Gedit).

Best regards,

Emilien

[vadz]

Just adding jens to the cc in the hope he might be able to look at this.

[jens]

Replying to vadz:

Just adding jens to the cc in the hope he might be able to look at this.

I will look into it.

[jens]

Just for the record:
It's not a tabart(gtk) problem.
The tabart-classes draw the tab-control, but not the part that contains the pane assigend to the tab.

Changes have to be done in the dockart, floatpane and framemanager sources.
I think it should be possible to add something like dockartgtk.

But this will (most likely) take a little longer, than just fixing existing drawing code in tabartgtk.

Nevertheless: I start working on it.

[jens]

I attach a patch, that fixes the described issue.
The patch let the notebooks render the pan-border themselves, instead of doing this in dockart.cpp.
The size of the tab's content-window will be decreased accordingly.

[vadz]

Looks fine to me, thanks!

Malcolm, OK to apply or would you prefer to wait for your merge/include this in it?

[mmacleod]

Think you can go ahead on this one, thanks.

[vadz]

Unfortunately applying the patch results in the following when running aui sample under Linux:

(auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion `GDK_IS_DRAWABLE (drawable)' failed

(auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth == gdk_drawable_get_depth (window)' failed

(auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion `GDK_IS_DRAWABLE (drawable)' failed

(auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth == gdk_drawable_get_depth (window)' failed

(auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion `GDK_IS_DRAWABLE (drawable)' failed

(auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth == gdk_drawable_get_depth (window)' failed

(auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion `GDK_IS_DRAWABLE (drawable)' failed

(auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth == gdk_drawable_get_depth (window)' failed

Could you please look into this Jens? TIA!

[jens]

updated patch, fix Gdk-CRITICAL

[jens]

The updated patch should fix this issue.

Sorry for the inconvenience.

Jens

[VZ]

(In [72641]) Improve wxAuiNotebook appearance when using some GTK themes.

Let wxAuiNotebook render the border itself, instead of doing it in dock art
class. This allows the notebook to do it correctly for the current theme.

Closes #14710.

[LukasK]

Attached a screenshot of an error occuring in my application on Windows 7 after r72641.

[vadz]

I don't see this immediately on sample startup but I do see it if I reduce and increase back the main window height in the aui sample.

[jens]

I can look into it this evening.

[jens]

A little later, but this patch fixes the issue.

[jens]

Fix for regression introduced in 72641.

[LukasK]

The patch (fix_for_regression_introduced_in_72641.patch) removed the refresh problem in my application.
Thanks!

[vadz]

Thanks Jens!

Should this be also applied to the dynamic notebook branch?

[VZ]

(In [72720]) Fix border size computation in wxAuiTabArt.

Space was reserved for the borders even when it wasn't filled, resulting in
visual artefacts. Fix this by virtualizing the function returning the
additional space needed for the borders and only overriding it to return non
zero in wxAuiGtkTabArt.

Closes #14710.

[jens]

Replying to vadz:

Thanks Jens!

Should this be also applied to the dynamic notebook branch?

No, it is not included in the branch and needs to be reimplemented.