wxLocalFSHandler::OpenFile() is constructing wxFSFile with incomplete location
|Reported by:||wsu||Owned by:|
|Keywords:||wxLocalFSHandler wxFSFile GetLocation||Cc:||vaclavslavik|
The wxFSFile::GetLocation() docs say the returned string includes the protocol. Also, if you look at handlers, e.g. wxMemoryFSHandlerBase and wxArchiveFSHandler, they provide the full location information when creating wxFSFile. However, wxLocalFSHandler::OpenFile() does not create the wxFSFile with protocol information.
This can be seen when running the html/help sample in wxMSW. If you use File | Help to open the help viewer, and then push the Next (wxID_HTML_DOWN) button, nothing happens. However, if you apply the attached patch, the Next button will work (as will the Previous button). The problem is that the wxHtmlBookRecord objects are being passed the wxFSFile::GetLocation() values, but those values are only partial matches for the keys used by wxHtmlHelpWindow::m_PagesHash.
Change History (5)
Changed 5 years ago by wsu
comment:1 Changed 4 years ago by vadz
- Cc vaclavslavik added
- Milestone set to 2.9.5
- Status changed from new to confirmed