wxStyledTextCtrl::GetLineText() bugfix

[troelsk]

The implementation is wrong, trailing newline(s) are not stripped

virtual wxString GetLineText(long n) const { return GetLine(n); }

[troelsk]

Trunk

[vadz]

Thanks, this does look like the right thing to do (pity that we don't have any unit tests for this control, such basic stuff wouldn't get broken if we had them...). I just wonder if using find_last_not_of("\r\n") wouldn't be slightly better than this manual iterator stuff?

[troelsk]

Trunk

[troelsk]

I did not know of that method, find_last_not_of(). It works ok in my testbed. New patch.

[vadz]

Sorry, I don't think this is correct. If npos is returned the string should be cleared as it means that it consists entirely from EOL characters. Or am I missing something?

[troelsk]

Trunk

[troelsk]

Right. New patch again.
(moved the GetLineLength() implementation to wxTextAreaBase as it seems unrelated to wxSTC)

[vadz]

Sorry, I don't like making GetLineLength() non pure virtual, you should at least think about implementing it more efficiently than by getting the line length and returning it, normally it should be possible.

I'll apply the rest of the patch soon, thanks for fixing it.

[VZ]

(In [73140]) Strip EOL characters from wxStyledTextCtrl::GetLineText() return value.

For consistency with all the other wxTextCtrl-like classes, the value returned
by this method must not include line terminator characters (like '\n'). Notice
that Scintilla-specific GetLine() does still include them, for consistency
with the Scintilla API itself.

Closes #13646.

[troelsk]

Thanks!

Sorry, I don't like making GetLineLength() non pure virtual, you should at least think about implementing it more efficiently

Ok, makes sense.

The GetLineLength() modification slipped out from the commit. Added a new tiny patch.

[troelsk]

GetLineLength

[VZ]

(In [73150]) Also account for EOL chars correctly in wxStyledTextCtrl::GetLineLength().

Make GetLineLength() consistent with GetLineText() after the changes of
r73140.

Closes #13646.

[vadz]

Oops, sorry for not noticing this part of the patch and thanks for checking!