Opened 4 years ago

Closed 22 months ago

#12921 closed enhancement (fixed)

Correcting wxSplitterWindow SashDrawing in wxOSX_COCOA

Reported by: retrakker Owned by: csomor
Priority: normal Milestone: 3.0.0
Component: wxOSX-Cocoa Version: stable-latest
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

This patch is trying to imitate the original NSSplitView sash drawing better. I have no Carbon build, so this needs to be checked but overall the size should reflect what NSSplitView is normally doing. Especially wxSP_THIN_SASH (aka 0) should be 1px on Cocoa and there are only adornments on 3D sashes.

Attachments (1)

wxOSX_Cocoa_SashSize.patch download (3.0 KB) - added by retrakker 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by retrakker

comment:1 Changed 4 years ago by csomor

  • Owner set to csomor
  • Status changed from new to accepted

thanks for the patch

comment:2 Changed 22 months ago by vadz

To be honest, I'm not totally sure if this is really better as the sash in the splitter sample now seems too thick. But the patch goes in the right direction by overriding GetSplitterParams() so let me commit this and then we can tune the constants used there later.

comment:3 Changed 22 months ago by VZ

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [72808]) Improve splitter appearance in wxOSX/Cocoa.

Try to imitate NSSplitView better.

Closes #12921.

Note: See TracTickets for help on using tickets.