Ticket #12921 (closed enhancement: fixed)

Opened 2 years ago

Last modified 7 months ago

Correcting wxSplitterWindow SashDrawing in wxOSX_COCOA

Reported by: retrakker Owned by: csomor
Priority: normal Milestone: 3.0
Component: wxOSX-Cocoa Version: 2.9-svn
Keywords: Cc:
Blocked By: Patch: yes
Blocking:

Description

This patch is trying to imitate the original NSSplitView sash drawing better. I have no Carbon build, so this needs to be checked but overall the size should reflect what NSSplitView is normally doing. Especially wxSP_THIN_SASH (aka 0) should be 1px on Cocoa and there are only adornments on 3D sashes.

Attachments

wxOSX_Cocoa_SashSize.patch download (3.0 KB) - added by retrakker 2 years ago.

Change History

Changed 2 years ago by retrakker

Changed 2 years ago by csomor

  • owner set to csomor
  • status changed from new to accepted

thanks for the patch

Changed 7 months ago by vadz

To be honest, I'm not totally sure if this is really better as the sash in the splitter sample now seems too thick. But the patch goes in the right direction by overriding GetSplitterParams() so let me commit this and then we can tune the constants used there later.

Changed 7 months ago by VZ

  • status changed from accepted to closed
  • resolution set to fixed

(In [72808]) Improve splitter appearance in wxOSX/Cocoa.

Try to imitate NSSplitView better.

Closes #12921.

Note: See TracTickets for help on using tickets.