Multi-line wxButton labels

[JacekK]

If label text contains escape sequences, wxButton label setting behaviour is platform dependent. Here are two methods for setting button label text:
1)

btn = wx.Button(parent, -1, "This is\nlabel")

2)

btn = wx.Button(parent, -1)
btn.SetLabel("This is\nlabel")

On GTK/Linux both (1) and (2) method works fine.
On Windows platform, method (1) works, but (2) doesn't.
On OS X, method (1) doesn't work but (2) works.

Example images for Windows platform


and OS X


Is this by design?

[vadz]

This is definitely not by design and is a bug but this bug was already fixed in wxMSW 2.9. I think it was also fixed under wxOSX but I'm not sure, can anybody please test there? Here is a simple patch to use for testing:

samples/minimal/minimal.cpp

@@ -172 +172 @@
     CreateStatusBar(2);
     SetStatusText("Welcome to wxWidgets!");
 #endif // wxUSE_STATUSBAR
+
+    new wxButton(this, -1, "A multi\nline button", wxPoint(5, 5));
+    (new wxButton(this, -1, "", wxPoint(5, 55)))->SetLabel("Another\none");
 }
 
 

[JacekK]

In wxPython, if I use multi-line label on instantiation, every further label changing works, e.g.:

		wb = wx.Button(self, -1, "\n")
		wb.SetLabel("This is\nalabel")

[vadz]

The question remains whether the original problem still exists in wxOSX 2.9.1 or not. If it's fixed there, the bug can be closed.

[robind]

No, wxOSX 2.9.1 still has the bug. (This is with the 2.9.1 tag, I don't have a workspace with the trunk version currently) I've added some multi-line buttons to the wxPython demo:

        b = wx.Button(self, 60, "Multi-line\button", (20, 280))
        b = wx.Button(self, 70, pos=(160, 280))
        b.SetLabel("Another\nmulti-line")    

I'll attach screenshots for both carbon and cocoa builds.

[vadz]

Err, could it be because there is a typo in your ctor? It uses \button, not \nbutton, and the screenshots seem to indicate that the typo is not only here as "b" doesn't appear in the buttons labels.

[disc]

I attached the results using trunk r65587 with the patch provided for minimal. Left is Carbon, on the right is Cocoa.

[vadz]

Thanks!

So at least for Cocoa using '\n' in the label in ctor does work -- it just doesn't set the button size correctly.

But I seem to remember that the normal buttons height can't be changed in Cocoa at all. So we'd need to use the square buttons for them presumably to make them appear correctly.

Stefan, is this right?

[VZ]

(In [72886]) Update the button bezel to account for multi-line labels in wxOSX.

If a button was created using a normal single-line label (including empty one)
and then its label was changed to something multi-line later, its size stayed
wrong in wxOSX as it still used the fixed size bezel used by normal buttons.

Adjust the bezel after each bezel change now to update the size of the button
if necessary.

Closes #12491.