wxPostScriptDC ignores pen's join and cap

[bernhard]

The wxPostScriptDC ignores the join and cap styles of
the pen.

I observed this originally on the WX_2_4_BRANCH but
judging from the source code this bug is also present
in HEAD.

[wojdyr]

see also #2936

[oneeyeman]

Is wxPostScriptDC still been used?

[oneeyeman]

Since #2936 has been closed, I think it's time to close this one as well...

[Mojo]

wxPostScriptDC still ignores pen's join and cap.
In windows it's OK but in linux it isn't.
I have ubuntu 10.04.3 , wxGTK-2.8.10, gcc version 4.4.3

[vadz]

Yes, there is no mention of wxPenJoin nor wxPenCap in this code.

I think PostScript actually does support both pen options so it should be possible to implement this and probably it even should be relatively simple so any patches from people interested in this functionality would be very welcome.

[oneeyeman]

Attached please find the first try to implement the functionality needed.
The code compiles cleanly and the printing sample compiles as well.

However I don't have a way to test this as I don't have a PS printer.
Could someone please try it and let me know.

Thank you.

[vadz]

FWIW you don't need to print PS output, you can just open it in Ghostscript or any other PS viewer.

[oneeyeman]

Vadim,

Which sample I can use to test it? "printing"?

Replying to vadz:

FWIW you don't need to print PS output, you can just open it in Ghostscript or any other PS viewer.

[vadz]

Well, it's the only sample using this class. So either you use it (after adding code testing various joins/caps to it) or you write a new test...

[vadz]

BTW, looking at the patch, what's the meaning of buffer << n in it? AFAICS it should be simply buffer = n...

[oneeyeman]

Vadim,
I don't know (don't remember). I think I got compiler error, but not sure.
In any case it should be tested and maybe you are right.

[oneeyeman]

Vadim,
Replying to oneeyeman:

Vadim,
I don't know (don't remember). I think I got compiler error, but not sure.
In any case it should be tested and maybe you are right.

Yes, got a compiler error:

C:\wxWidgets\src\generic\dcpsg.cpp(1210) : error C2248: '=' : cannot access private member declared in class 'wxString'

..\..\include\wx/string.h(461) : see declaration of '='

But the patch for some reason does not work. The resulting page is empty.
I will try to see what is happenning if time permits.

[oneeyeman]

First try to implementation

[oneeyeman]

Fix compilation of PostScript printing on Windows

[oneeyeman]

Attached please find 2 patches: first is 1244.patch which implements the functionality missing that is referenced by this ticket, second is msw_ps.patch which fixes the compilation of printing sample with the postscript printing.

Everything works as expected.

Please apply.

[vadz]

I don't understand how could this work, you're appending to the buffer which already had some contents so you're printing it out twice. I've fixed it blindly as I still have no test code for this...

[VZ]

(In [73628]) Test PostScript printing in the print sample if it is compiled in.

Just use wxUSE_POSTSCRIPT instead of wxTEST_POSTSCRIPT_IN_MSW and also do it
under all platforms, not just MSW.

See #1244.

[VZ]

(In [73629]) Implement support for pen cap and join in wxPostScriptDC.

Use PostScript "setlinecap" and "setlinejoin" commands to do it.

Closes #1244.