Opened 9 years ago

Closed 4 months ago

#12419 closed enhancement (fixed)

wxCB_SORT not implemented in wxOSX/Cocoa

Reported by: joostn Owned by:
Priority: normal Milestone:
Component: wxOSX Version: stable-latest
Keywords: Cc: joost@…
Blocked By: Blocking:
Patch: no

Description

The html help demo shows an assert upon startup on Cocoa about missing wxCB_SORT support. Since it's used just for the bookmarks combobox it might be a good idea to remove wxCB_SORT from the wxHtmlHelpWindow for now on Cocoa. See patch.

Attachments (1)

helpwnd_combobox.patch download (1.0 KB) - added by joostn 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by joostn

comment:1 Changed 9 years ago by vadz

  • Status changed from new to confirmed

FWIW I posted recently to wx-dev (but can't find this post in the archives for some reason) about implementing sorted combobox under Mac using a custom data source. It doesn't seem like it'd be difficult to this...

comment:2 Changed 8 years ago by vadz

  • Milestone set to 3.0

Would be really nice to implement wxCB_SORT for wxOSX/Cocoa. Failing this we should at least apply this patch before 3.0 as it's better than nothing.

comment:3 Changed 8 years ago by vadz

  • Milestone 3.0 deleted
  • Patch unset
  • Summary changed from [wxOSX-Cocoa] wxHtmlHelpWindow asserts about unsupported wxCB_SORT to wxCB_SORT not implemented in wxOSX/Cocoa

Julian just did this in r70828 but I'm keeping this open with a different title.

comment:4 Changed 4 years ago by Vadim Zeitlin <vadim@…>

In fea37f4984e36cde8cbd7829c151795f49d89e3b/git-wxWidgets:

Don't assert when creating wxComboBox with wxCB_SORT in wxOSX

Partially undo the changes of 8e7262fca7520f73e711981019c6407ee84e5e26: using
wxLogWarning() was wrong, but using asserts is not really great neither as it
results in crashes, and prevents from using, some samples.

Also at least document that this style is not supported.

See #12419.

comment:5 Changed 4 months ago by oneeyeman

  • Resolution set to fixed
  • Status changed from confirmed to closed

This feature is now implemented by ab7ba98dbca12eb61a93ab1393121cfb7ef22ec5.

Note: See TracTickets for help on using tickets.