Opened 11 years ago

Closed 6 years ago

#1230 closed defect (fixed)

wxGrid::SetColFormatCustom() does not change the cell-editor

Reported by: alex_82 Owned by:
Priority: normal Milestone:
Component: GUI-generic Version:
Keywords: wxGrid Cc: alex_82
Blocked By: Blocking:
Patch: yes

Description

wxGrid::SetColFormatCustom() does only change the
renderer of a column but not the editor.

adding following two lines fixes the problem:

wxGridCellEditor *editor =
GetDefaultEditorForType(typeName);
attr->SetEditor(editor);

Attachments (1)

SetColFormatCustom.patch download (399 bytes) - added by alex_82 11 years ago.
fix for wxGrid::SetColFormatCustom()

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by alex_82

fix for wxGrid::SetColFormatCustom()

comment:1 Changed 11 years ago by alex_82

i have made a diff file which fixs the problem. it only adds
the 2 lines to wxGrid::SetColFormatCustom().

comment:2 Changed 6 years ago by wojdyr

  • Keywords wxGrid added
  • Patch set
  • Status changed from new to infoneeded_new

Thanks. Do you know if the patch is still relevant?

comment:3 Changed 6 years ago by neis

  • Resolution set to fixed
  • Status changed from infoneeded_new to closed

By looking at the source code, it looks like the patch is obviously still relevant.
I've applied the patch to trunk (r54232) since it definitly looks like a good idea to me. However, I'm unsure if it should be backported or not. IMO it fixes a real problem and probably shouldn't harm workarounds in existing applications, OTOH if the application is setting an editor which doesn't correspond to the column format's default editor _prior_ to calling SetColFormatCustom, if will be adversly affected, but that case seems rather improbable to me. Opinions?

Note: See TracTickets for help on using tickets.