Opened 4 years ago

Closed 4 years ago

#11679 closed defect (fixed)

Patch: Subclassing of wxMenuBar in XRC

Reported by: botg Owned by:
Priority: normal Milestone: 2.8.11
Component: XRC Version:
Keywords: wxMenuBar subclassing XRC Cc:
Blocked By: Blocking:
Patch: yes

Description

This patch allows the subclassing of wxMenuBar if loaded from an XRC file.

wxMenuBarXmlHandler::DoCreateResource did not check if m_instance was already existing and did always create a new wxMenuBar, causing the subclasing to fail and some memory to be leaked.

The patch applies to both 2.8 as well as trunk.

It would be nice to include this fix in 2.8.11 if there is still time.

Attachments (1)

xrc_menubar.patch download (620 bytes) - added by botg 4 years ago.

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by botg

comment:1 Changed 4 years ago by vaclavslavik

  • Milestone set to 2.8.11
  • Resolution set to fixed
  • Status changed from new to closed

Thanks! Applied.

Note: See TracTickets for help on using tickets.