Assert in notebook sample when changing book control type

[triton]

Open the Notebook sample and try to switch to Toolbook and it crashes.

I'm using Windows 7 and wxWidgets 2.9. I'll try later with 2.9.1 once I compile it.

[vadz]

Works for me with current svn, if it still fails for you please provide a backtrace, thanks!

[catalin]

Same as #11492 ?

[triton]

I can confirm this is working on. But I managed to get an assert somehow just by playing with the demo.

​http://i48.tinypic.com/15zm4g8.png

[vadz]

Would you have any hints about how can this be reproduced?

For future reference (in case the URL above goes away), the assert is in MyFrame::RecreateBook().

[triton]

Stacktrace of assert

[triton]

I added the screenshot as an attachment for later reference.

I'll try to re-create the assert, but I don't know if I'll be able to... I should have saved the operations log in the sample. :)

[triton]

Damn sorry, this set to 'closed' automatically, wtf... Re-opened.

[wojdyr]

it's probably the case when wxToolbook is created with unchecked Show Images.

../src/generic/toolbkg.cpp(300): assert "GetImageList() != __null" failed in InsertPage()

[vadz]

Indeed, thanks Marcin. Looking at the code, wxToolbook simply doesn't support not showing the images so I think the sample should be fixed to avoid using it in this case. In principle it could be possible to have a toolbar without images but I am not sure if it's really useful in practice.

[wojdyr]

i agree,
here is a small change that prevents assertion:

--- notebook.cpp        (revision 67192)
+++ notebook.cpp        (working copy)
@@ -552,6 +552,11 @@
     {
         m_bookCtrl->SetImageList(m_imageList);
     }
+    else if ( m_type == Type_Toolbook )
+    {
+        wxLogMessage(wxT("wxToolbook does not work without images!"));
+        m_bookCtrl->SetImageList(m_imageList);
+    }
 
     if ( oldBook )
     {

[VZ]

(In [67201]) Always use icons with wxToolbook in the notebook sample.

wxToolbook asserts and doesn't work if it has no images so always use them
with it in the sample to avoid it.

Closes #11656.