Opened 4 years ago

Closed 4 weeks ago

#11649 closed defect (port to stable)

wxrc generates code which contains _T() macro instead of wxT() macro

Reported by: BrianCameron Owned by:
Priority: normal Milestone:
Component: base Version:
Keywords: Cc:
Blocked By: Blocking:
Patch: no

Description

The wxrc program generates code which contains _T() macro instead of the wxT() macro

Note that we worked hard to fix bug #10660. The _T macro does not work with the Sun Stuio compiler, and fixing bug #10660 makes it possible to build wxWidgets code with the Sun Studio compiler as long as the wxT() macro is used instead of the _T() macro.

However, the wxrc program still generates coe which contains the _T() macro so you need to hand-edit the generated code to compile it. It would be better if wxrc generated code that used the wxT() macro instead.

For example, see pgadmin xrcdialogs.cpp

http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/postgres/pgadmin/pgadmin3-1.10.0/pgadmin/ui/xrcDialogs.cpp

for example line:
26402 XRC_ADD_FILE(wxT("XRC_resource/xrcDialogs.cpp$._dlgAddFavourite.xrc"), xml_res_file_0, xml_res_size_0, _T("text/xml"));

Can this issue be fixed?

Change History (4)

comment:1 Changed 4 years ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [63231]) Output wxT() and not _T() in code generated by wxrc.

Also use wxT() in wxrc.cpp itself, just to be sure that there are no other
occurrences of _T() left.

Closes #11649.

comment:2 Changed 4 years ago by BrianCameron

Thank you for fixing this so quickly. Would you mind sharing the patch? For our Solaris builds, we obviously need to apply the patch to fix this for wxWidgets to work as well as it should. If you could provide the patch used to fix this problem, we can ensure that Solaris delivers with this fix.

Thanks,

Brian.Cameron@…

comment:3 Changed 4 years ago by vadz

  • Resolution changed from fixed to port to stable
  • Status changed from closed to portneeded

If you follow the link to r63231 above you can see the "Download" link at the bottom of the page.

comment:4 Changed 4 weeks ago by vadz

  • Status changed from portneeded to closed

As we don't plan to make any more 2.8 releases, closing all bugs with "port to 2.8 needed" status.

Note: See TracTickets for help on using tickets.